From 80873f974a9e7f50ac6cf64cda2bb9313db5ea99 Mon Sep 17 00:00:00 2001 From: Michael Drake Date: Fri, 5 Feb 2016 16:16:30 +0000 Subject: Fix: Proper copy constructor for HTMLDListElement. --- src/html/html_dlist_element.c | 35 ++++++++++++++++++++++++++++++++--- src/html/html_dlist_element.h | 9 +++++++++ 2 files changed, 41 insertions(+), 3 deletions(-) diff --git a/src/html/html_dlist_element.c b/src/html/html_dlist_element.c index e2fccc9..ab9d4c3 100644 --- a/src/html/html_dlist_element.c +++ b/src/html/html_dlist_element.c @@ -137,9 +137,38 @@ void _dom_virtual_html_dlist_element_destroy(dom_node_internal *node) } /* The virtual copy function, see src/core/node.c for detail */ -dom_exception _dom_html_dlist_element_copy(dom_node_internal *old, - dom_node_internal **copy) +dom_exception _dom_html_dlist_element_copy( + dom_node_internal *old, dom_node_internal **copy) { - return _dom_html_element_copy(old, copy); + dom_html_dlist_element *new_node; + dom_exception err; + + new_node = malloc(sizeof(dom_html_dlist_element)); + if (new_node == NULL) + return DOM_NO_MEM_ERR; + + err = dom_html_dlist_element_copy_internal(old, new_node); + if (err != DOM_NO_ERR) { + free(new_node); + return err; + } + + *copy = (dom_node_internal *) new_node; + + return DOM_NO_ERR; +} + +dom_exception _dom_html_dlist_element_copy_internal( + dom_html_dlist_element *old, + dom_html_dlist_element *new) +{ + dom_exception err; + + err = dom_html_element_copy_internal(old, new); + if (err != DOM_NO_ERR) { + return err; + } + + return DOM_NO_ERR; } diff --git a/src/html/html_dlist_element.h b/src/html/html_dlist_element.h index aeca232..ff6a6e4 100644 --- a/src/html/html_dlist_element.h +++ b/src/html/html_dlist_element.h @@ -49,4 +49,13 @@ dom_exception _dom_html_dlist_element_copy(dom_node_internal *old, _dom_virtual_html_dlist_element_destroy, \ _dom_html_dlist_element_copy +/* Helper functions*/ +dom_exception _dom_html_dlist_element_copy_internal( + dom_html_dlist_element *old, + dom_html_dlist_element *new); +#define dom_html_dlist_element_copy_internal(o, n) \ + _dom_html_dlist_element_copy_internal( \ + (dom_html_dlist_element *) (o), \ + (dom_html_dlist_element *) (n)) + #endif -- cgit v1.2.3