From c4b0e2af4ea514ed9244338a0098de89cdcec7ca Mon Sep 17 00:00:00 2001 From: Michael Drake Date: Fri, 5 Feb 2016 17:36:18 +0000 Subject: Fix: Proper copy constructor for HTMLPreElement. --- src/html/html_pre_element.c | 35 ++++++++++++++++++++++++++++++++--- src/html/html_pre_element.h | 9 +++++++++ 2 files changed, 41 insertions(+), 3 deletions(-) diff --git a/src/html/html_pre_element.c b/src/html/html_pre_element.c index 502e4d8..64c8c3d 100644 --- a/src/html/html_pre_element.c +++ b/src/html/html_pre_element.c @@ -133,9 +133,38 @@ void _dom_virtual_html_pre_element_destroy(dom_node_internal *node) } /* The virtual copy function, see src/core/node.c for detail */ -dom_exception _dom_html_pre_element_copy(dom_node_internal *old, - dom_node_internal **copy) +dom_exception _dom_html_pre_element_copy( + dom_node_internal *old, dom_node_internal **copy) { - return _dom_html_element_copy(old, copy); + dom_html_pre_element *new_node; + dom_exception err; + + new_node = malloc(sizeof(dom_html_pre_element)); + if (new_node == NULL) + return DOM_NO_MEM_ERR; + + err = dom_html_pre_element_copy_internal(old, new_node); + if (err != DOM_NO_ERR) { + free(new_node); + return err; + } + + *copy = (dom_node_internal *) new_node; + + return DOM_NO_ERR; +} + +dom_exception _dom_html_pre_element_copy_internal( + dom_html_pre_element *old, + dom_html_pre_element *new) +{ + dom_exception err; + + err = dom_html_element_copy_internal(old, new); + if (err != DOM_NO_ERR) { + return err; + } + + return DOM_NO_ERR; } diff --git a/src/html/html_pre_element.h b/src/html/html_pre_element.h index d9dc6d8..0a5e422 100644 --- a/src/html/html_pre_element.h +++ b/src/html/html_pre_element.h @@ -49,4 +49,13 @@ dom_exception _dom_html_pre_element_copy(dom_node_internal *old, _dom_virtual_html_pre_element_destroy, \ _dom_html_pre_element_copy +/* Helper functions*/ +dom_exception _dom_html_pre_element_copy_internal( + dom_html_pre_element *old, + dom_html_pre_element *new); +#define dom_html_pre_element_copy_internal(o, n) \ + _dom_html_pre_element_copy_internal( \ + (dom_html_pre_element *) (o), \ + (dom_html_pre_element *) (n)) + #endif -- cgit v1.2.3