From c20fc71c3c911183f0700bd0fdd856fccd360280 Mon Sep 17 00:00:00 2001 From: Vincent Sanders Date: Fri, 24 Jan 2014 12:32:52 +0000 Subject: ensure dom_implementation_create_document_type() parameters are present (coverity 1127076) --- src/core/implementation.c | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'src/core') diff --git a/src/core/implementation.c b/src/core/implementation.c index 7380771..6f8db45 100644 --- a/src/core/implementation.c +++ b/src/core/implementation.c @@ -67,13 +67,15 @@ dom_exception dom_implementation_create_document_type( dom_string *public_id_s = NULL, *system_id_s = NULL; dom_exception err; - if (qname != NULL) { - err = dom_string_create((const uint8_t *) qname, - strlen(qname), &qname_s); - if (err != DOM_NO_ERR) - return err; + if (qname == NULL) { + return DOM_INVALID_CHARACTER_ERR; } + err = dom_string_create((const uint8_t *) qname, + strlen(qname), &qname_s); + if (err != DOM_NO_ERR) + return err; + err = _dom_namespace_split_qname(qname_s, &prefix, &lname); if (err != DOM_NO_ERR) { dom_string_unref(qname_s); -- cgit v1.2.3