From 89b61e8483cac27ea23c840d7a68c5243de97421 Mon Sep 17 00:00:00 2001 From: Daniel Silverstone Date: Sat, 15 Nov 2014 10:13:54 +0000 Subject: Fix unref issue with html collection in applets callback. Coverity #1227072 --- src/html/html_document.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) (limited to 'src/html/html_document.c') diff --git a/src/html/html_document.c b/src/html/html_document.c index f6808e7..ac0469c 100644 --- a/src/html/html_document.c +++ b/src/html/html_document.c @@ -757,10 +757,11 @@ bool applets_callback(struct dom_node_internal *node, void *ctx) ((dom_html_document *)ctx)->memoised[hds_OBJECT])) { uint32_t len = 0; dom_html_collection *applets; - _dom_html_collection_create(ctx, node, - applet_callback, ctx, &applets); - + if (_dom_html_collection_create(ctx, node, + applet_callback, ctx, &applets) != DOM_NO_ERR) + return false; dom_html_collection_get_length(applets, &len); + dom_html_collection_unref(applets); if(len != 0) return true; } -- cgit v1.2.3