From 609e19e6f68121010f80623835398293d52c9fdc Mon Sep 17 00:00:00 2001 From: Michael Drake Date: Fri, 5 Feb 2016 17:47:38 +0000 Subject: Fix: Proper copy constructor for HTMLTableElement. --- src/html/html_table_element.h | 9 +++++++++ 1 file changed, 9 insertions(+) (limited to 'src/html/html_table_element.h') diff --git a/src/html/html_table_element.h b/src/html/html_table_element.h index 4e4747c..4e757cc 100644 --- a/src/html/html_table_element.h +++ b/src/html/html_table_element.h @@ -48,6 +48,15 @@ dom_exception _dom_html_table_element_copy(dom_node_internal *old, _dom_virtual_html_table_element_destroy, \ _dom_html_table_element_copy +/* Helper functions*/ +dom_exception _dom_html_table_element_copy_internal( + dom_html_table_element *old, + dom_html_table_element *new); +#define dom_html_table_element_copy_internal(o, n) \ + _dom_html_table_element_copy_internal( \ + (dom_html_table_element *) (o), \ + (dom_html_table_element *) (n)) + #endif bool table_rows_callback(struct dom_node_internal *node, void *ctx); -- cgit v1.2.3 From 778271539bfe1e7152e71768a008fec452d0aa6b Mon Sep 17 00:00:00 2001 From: Michael Drake Date: Fri, 5 Feb 2016 17:50:40 +0000 Subject: Cleanup: Remove odd declaration of callbacks outside header guard. --- src/html/html_table_element.c | 4 ++-- src/html/html_table_element.h | 2 -- 2 files changed, 2 insertions(+), 4 deletions(-) (limited to 'src/html/html_table_element.h') diff --git a/src/html/html_table_element.c b/src/html/html_table_element.c index e905f85..b74ea41 100644 --- a/src/html/html_table_element.c +++ b/src/html/html_table_element.c @@ -380,7 +380,7 @@ dom_exception dom_html_table_element_set_t_foot( * \param ctx The dom_html_document object (void *) * \return DOM_NO_ERR on success, appropriate dom_exception on failure. */ -bool table_rows_callback(struct dom_node_internal *node, void *ctx) +static bool table_rows_callback(struct dom_node_internal *node, void *ctx) { dom_html_document *doc = ctx; if(node->type == DOM_ELEMENT_NODE && @@ -414,7 +414,7 @@ dom_exception dom_html_table_element_get_rows( * \param ctx The dom_html_document object (void *) * \return DOM_NO_ERR on success, appropriate dom_exception on failure. */ -bool table_t_bodies_callback(struct dom_node_internal *node, void *ctx) +static bool table_t_bodies_callback(struct dom_node_internal *node, void *ctx) { dom_html_document *doc = ctx; if(node->type == DOM_ELEMENT_NODE && diff --git a/src/html/html_table_element.h b/src/html/html_table_element.h index 4e757cc..5f440fd 100644 --- a/src/html/html_table_element.h +++ b/src/html/html_table_element.h @@ -59,8 +59,6 @@ dom_exception _dom_html_table_element_copy_internal( #endif -bool table_rows_callback(struct dom_node_internal *node, void *ctx); -bool table_t_bodies_callback(struct dom_node_internal *node, void *ctx); dom_exception dom_html_table_element_create_t_body( dom_html_table_element *element, dom_html_table_section_element **t_body); -- cgit v1.2.3 From 103c582b3beb6db4d9f1d73c8aa9e7b7121cd977 Mon Sep 17 00:00:00 2001 From: Michael Drake Date: Fri, 5 Feb 2016 17:55:52 +0000 Subject: Cleanup: Don't put static function in header. --- src/html/html_table_element.c | 3 ++- src/html/html_table_element.h | 4 ---- 2 files changed, 2 insertions(+), 5 deletions(-) (limited to 'src/html/html_table_element.h') diff --git a/src/html/html_table_element.c b/src/html/html_table_element.c index b74ea41..7e8a508 100644 --- a/src/html/html_table_element.c +++ b/src/html/html_table_element.c @@ -432,6 +432,7 @@ static bool table_t_bodies_callback(struct dom_node_internal *node, void *ctx) * \param t_bodies The Status * \return DOM_NO_ERR on success, appropriate dom_exception on failure. */ + dom_exception dom_html_table_element_get_t_bodies( dom_html_table_element *element, dom_html_collection **t_bodies) @@ -674,7 +675,7 @@ dom_exception dom_html_table_element_delete_t_head( * \param t_head The Status * \return DOM_NO_ERR on success, appropriate dom_exception on failure. */ -dom_exception dom_html_table_element_create_t_body( +static dom_exception dom_html_table_element_create_t_body( dom_html_table_element *element, dom_html_table_section_element **t_body) { diff --git a/src/html/html_table_element.h b/src/html/html_table_element.h index 5f440fd..eed6a4a 100644 --- a/src/html/html_table_element.h +++ b/src/html/html_table_element.h @@ -58,7 +58,3 @@ dom_exception _dom_html_table_element_copy_internal( (dom_html_table_element *) (n)) #endif - -dom_exception dom_html_table_element_create_t_body( - dom_html_table_element *element, - dom_html_table_section_element **t_body); -- cgit v1.2.3