diff options
Diffstat (limited to 'src/charset/codecs/codec_ascii.c')
| -rw-r--r-- | src/charset/codecs/codec_ascii.c | 34 |
1 files changed, 18 insertions, 16 deletions
diff --git a/src/charset/codecs/codec_ascii.c b/src/charset/codecs/codec_ascii.c index f91b1e9..318e7f0 100644 --- a/src/charset/codecs/codec_ascii.c +++ b/src/charset/codecs/codec_ascii.c @@ -9,9 +9,10 @@ #include <stdlib.h> #include <string.h> -/* These two are for htonl / ntohl */ -#include <arpa/inet.h> +/* These three are for htonl / ntohl */ +#include <sys/types.h> #include <netinet/in.h> +#include <arpa/inet.h> #include <parserutils/charset/mibenum.h> @@ -77,7 +78,7 @@ bool charset_ascii_codec_handles_charset(const char *charset) static uint16_t ascii; uint16_t match = parserutils_charset_mibenum_from_name(charset, strlen(charset)); - + if (ascii == 0) { ascii = parserutils_charset_mibenum_from_name( "US-ASCII", SLEN("US-ASCII")); @@ -184,7 +185,7 @@ parserutils_error charset_ascii_codec_encode(parserutils_charset_codec *codec, uint32_t *pwrite = c->write_buf; while (c->write_len > 0) { - error = charset_ascii_from_ucs4(c, pwrite[0], + error = charset_ascii_from_ucs4(c, pwrite[0], dest, destlen); if (error != PARSERUTILS_OK) { uint32_t len; @@ -204,13 +205,13 @@ parserutils_error charset_ascii_codec_encode(parserutils_charset_codec *codec, /* Now process the characters for this call */ while (*sourcelen > 0) { - ucs4 = ntohl(*((uint32_t *) (void *) *source)); + ucs4 = (uint32_t) ntohl(*((uint32_t *) (void *) *source)); towrite = &ucs4; towritelen = 1; /* Output current characters */ while (towritelen > 0) { - error = charset_ascii_from_ucs4(c, towrite[0], dest, + error = charset_ascii_from_ucs4(c, towrite[0], dest, destlen); if (error != PARSERUTILS_OK) { uint32_t len; @@ -265,9 +266,9 @@ parserutils_error charset_ascii_codec_encode(parserutils_charset_codec *codec, * read, if the result is _OK or _NOMEM. Any remaining output for the * character will be buffered by the codec for writing on the next call. * - * In the case of the result being _INVALID, ::source will point _at_ the - * last input character read; nothing will be written or buffered for the - * failed character. It is up to the client to fix the cause of the failure + * In the case of the result being _INVALID, ::source will point _at_ the + * last input character read; nothing will be written or buffered for the + * failed character. It is up to the client to fix the cause of the failure * and retry the decoding process. * * Note that, if failure occurs whilst attempting to write any output @@ -301,7 +302,8 @@ parserutils_error charset_ascii_codec_decode(parserutils_charset_codec *codec, uint32_t *pread = c->read_buf; while (c->read_len > 0 && *destlen >= c->read_len * 4) { - *((uint32_t *) (void *) *dest) = htonl(pread[0]); + *((uint32_t *) (void *) *dest) = + (uint32_t) htonl(pread[0]); *dest += 4; *destlen -= 4; @@ -371,9 +373,9 @@ parserutils_error charset_ascii_codec_reset(parserutils_charset_codec *codec) * read, if the result is _OK or _NOMEM. Any remaining output for the * character will be buffered by the codec for writing on the next call. * - * In the case of the result being _INVALID, ::source will point _at_ the - * last input character read; nothing will be written or buffered for the - * failed character. It is up to the client to fix the cause of the failure + * In the case of the result being _INVALID, ::source will point _at_ the + * last input character read; nothing will be written or buffered for the + * failed character. It is up to the client to fix the cause of the failure * and retry the decoding process. * * ::sourcelen will be reduced appropriately on exit. @@ -407,9 +409,9 @@ parserutils_error charset_ascii_codec_read_char(charset_ascii_codec *c, return error; } else if (error == PARSERUTILS_INVALID) { /* Illegal input sequence */ - + /* Strict errormode; simply flag invalid character */ - if (c->base.errormode == + if (c->base.errormode == PARSERUTILS_CHARSET_CODEC_ERROR_STRICT) { return PARSERUTILS_INVALID; } @@ -451,7 +453,7 @@ parserutils_error charset_ascii_codec_output_decoded_char( return PARSERUTILS_NOMEM; } - *((uint32_t *) (void *) *dest) = htonl(ucs4); + *((uint32_t *) (void *) *dest) = (uint32_t) htonl(ucs4); *dest += 4; *destlen -= 4; |