make image content handlers title setting use the heap instead of the stack and remove the possibility of buffer overruns

1 files changed, 8 insertions, 3 deletions

diff --git a/image/webp.c b/image/webp.c
index acf226b5f..fc4356c01 100644
--- a/image/webp.c
+++ b/image/webp.c
@@ -78,7 +78,7 @@ static bool webp_convert(struct content *c)
 	unsigned char *imagebuf = NULL;
 	unsigned long size;
 	int width = 0, height = 0;
-	char title[512];
+	char *title;
 	int res = 0;
 	uint8_t *res_p = NULL;
 
@@ -116,10 +116,15 @@ static bool webp_convert(struct content *c)
 
 	c->width = width;
 	c->height = height;
-	snprintf(title, sizeof(title), messages_get("WebPTitle"),
+
+	/* set title */
+	title = messages_get_buff("WebPTitle",
 			nsurl_access_leaf(llcache_handle_get_url(c->llcache)),
 			c->width, c->height);
-	content__set_title(c, title);
+	if (title != NULL) {
+		content__set_title(c, title);
+		free(title);
+	}
 
 	bitmap_modified(webp->bitmap);