|author||John Mark Bell <firstname.lastname@example.org>||2007-08-29 00:27:52 +0000|
|committer||John Mark Bell <email@example.com>||2007-08-29 00:27:52 +0000|
Probably fix crash on clicking in url completion dialogue.
URL completion really needs revisiting, as it's full of side effects and has weird and wonderful interactions with other parts of the system. svn path=/trunk/netsurf/; revision=3535
Diffstat (limited to 'riscos')
1 files changed, 13 insertions, 3 deletions
diff --git a/riscos/url_complete.c b/riscos/url_complete.c
index d30443cf5..9085ba85c 100644
@@ -720,12 +720,22 @@ bool ro_gui_url_complete_click(wimp_pointer *pointer)
+ /** \todo The interaction of components here is hideous */
+ /* Do NOT make any attempt to use any of the global url
+ * completion variables after this call to browser_window_go.
+ * They will be invalidated by (at least):
+ * + gui_window_set_url
+ * + destruction of (i)frames within the current page
+ * Any attempt to use them will probably result in a crash.
/* Adjust just sets the text */