From 92caa16cfcd10ecc2024972fbef740fbdbd3254b Mon Sep 17 00:00:00 2001 From: Daniel Silverstone Date: Sun, 1 Dec 2019 17:25:49 +0000 Subject: Add missing unrefs Signed-off-by: Daniel Silverstone --- content/content.c | 3 +++ desktop/browser_window.c | 5 +++++ 2 files changed, 8 insertions(+) diff --git a/content/content.c b/content/content.c index a87be0022..552ee071e 100644 --- a/content/content.c +++ b/content/content.c @@ -592,6 +592,7 @@ bool content_saw_insecure_objects(struct hlcache_handle *h) &match) == lwc_error_ok && (match == true))) { /* No insecurity to find */ + lwc_string_unref(scheme); return false; } @@ -600,9 +601,11 @@ bool content_saw_insecure_objects(struct hlcache_handle *h) &match) == lwc_error_ok) && (match == false)) { /* I did see something insecure -- ME! */ + lwc_string_unref(scheme); return true; } + lwc_string_unref(scheme); /* I am supposed to be secure, but was I overridden */ if (urldb_get_cert_permissions(url)) { /* I was https:// but I was overridden, that's no good */ diff --git a/desktop/browser_window.c b/desktop/browser_window.c index 1fa3161bb..16fa73e17 100644 --- a/desktop/browser_window.c +++ b/desktop/browser_window.c @@ -4671,6 +4671,7 @@ browser_window_page_info_state browser_window_get_page_info_state( (lwc_string_isequal(scheme, corestring_lwc_resource, &match) == lwc_error_ok && (match == true))) { + lwc_string_unref(scheme); return PAGE_STATE_INTERNAL; } @@ -4678,6 +4679,7 @@ browser_window_page_info_state browser_window_get_page_info_state( if (lwc_string_isequal(scheme, corestring_lwc_file, &match) == lwc_error_ok && match == true) { + lwc_string_unref(scheme); return PAGE_STATE_LOCAL; } @@ -4686,9 +4688,12 @@ browser_window_page_info_state browser_window_get_page_info_state( &match) == lwc_error_ok && (match == false))) { /* Some remote content, not https, therefore insecure */ + lwc_string_unref(scheme); return PAGE_STATE_INSECURE; } + lwc_string_unref(scheme); + /* Did we have to override this SSL setting? */ if (urldb_get_cert_permissions(bw->current_parameters.url)) { return PAGE_STATE_SECURE_OVERRIDE; -- cgit v1.2.3