From c56642819eed87431dff3446fe111f7f3eefaa7d Mon Sep 17 00:00:00 2001 From: Vincent Sanders Date: Wed, 7 May 2014 16:14:18 +0100 Subject: add file operations table and make all frontends use it. This rationalises the path construction and basename file operations. The default implementation is POSIX which works for all frontends except windows, riscos and amiga which have differeing path separators and rules. These implementations are significantly more robust than the previous nine implementations and also do not use unsafe strncpy or buffers with arbitrary length limits. These implementations also carry full documentation comments. --- cocoa/fetch.m | 16 ---------------- 1 file changed, 16 deletions(-) (limited to 'cocoa') diff --git a/cocoa/fetch.m b/cocoa/fetch.m index 70d3805e1..8cc2cb966 100644 --- a/cocoa/fetch.m +++ b/cocoa/fetch.m @@ -107,20 +107,6 @@ static char *path_to_url(const char *path) absoluteString] UTF8String] ); } -static char *filename_from_path(char *path) -{ - return strdup( [[[NSString stringWithUTF8String: path] lastPathComponent] UTF8String] ); -} - -static bool path_add_part(char *path, int length, const char *newpart) -{ - NSString *newPath = [[NSString stringWithUTF8String: path] stringByAppendingPathComponent: [NSString stringWithUTF8String: newpart]]; - - strncpy( path, [newPath UTF8String], length ); - - return true; -} - static nsurl *gui_get_resource_url(const char *path) { nsurl *url = NULL; @@ -131,8 +117,6 @@ static nsurl *gui_get_resource_url(const char *path) } static struct gui_fetch_table fetch_table = { - .filename_from_path = filename_from_path, - .path_add_part = path_add_part, .filetype = fetch_filetype, .path_to_url = path_to_url, .url_to_path = url_to_path, -- cgit v1.2.3