From f6faa20a37f38643d505ba41baa8a88e3dfa545a Mon Sep 17 00:00:00 2001 From: Michael Drake Date: Tue, 6 Jul 2010 21:09:20 +0000 Subject: In switch statements add default branch for unknown enum values, with assert. svn path=/trunk/netsurf/; revision=10603 --- desktop/frames.c | 89 ++++++++++++++++++++++++++++++++++---------------------- 1 file changed, 54 insertions(+), 35 deletions(-) (limited to 'desktop/frames.c') diff --git a/desktop/frames.c b/desktop/frames.c index 663ebcdbf..ee9c31d6e 100644 --- a/desktop/frames.c +++ b/desktop/frames.c @@ -300,23 +300,33 @@ void browser_window_recalculate_frameset(struct browser_window *bw) { window = &bw->children[index]; switch (window->frame_width.unit) { - case FRAME_DIMENSION_PIXELS: - widths[col][row] = window->frame_width.value * - window->scale; - if (window->border) { - if (col != 0) - widths[col][row] += 1; - if (col != bw->cols - 1) - widths[col][row] += 1; - } - break; - case FRAME_DIMENSION_PERCENT: - widths[col][row] = bw_width * window->frame_width.value / 100; - break; - case FRAME_DIMENSION_RELATIVE: - widths[col][row] = 0; - relative += window->frame_width.value; - break; + case FRAME_DIMENSION_PIXELS: + widths[col][row] = window->frame_width.value * + window->scale; + if (window->border) { + if (col != 0) + widths[col][row] += 1; + if (col != bw->cols - 1) + widths[col][row] += 1; + } + break; + case FRAME_DIMENSION_PERCENT: + widths[col][row] = bw_width * + window->frame_width.value / 100; + break; + case FRAME_DIMENSION_RELATIVE: + widths[col][row] = 0; + relative += window->frame_width.value; + break; + default: + /* unknown frame dimension unit */ + assert(window->frame_width.unit == + FRAME_DIMENSION_PIXELS || + window->frame_width.unit == + FRAME_DIMENSION_PERCENT || + window->frame_width.unit == + FRAME_DIMENSION_RELATIVE); + break; } avail_width -= widths[col][row]; } @@ -359,24 +369,33 @@ void browser_window_recalculate_frameset(struct browser_window *bw) { window = &bw->children[index]; switch (window->frame_height.unit) { - case FRAME_DIMENSION_PIXELS: - heights[col][row] = window->frame_height.value * - window->scale; - if (window->border) { - if (row != 0) - heights[col][row] += 1; - if (row != bw->rows - 1) - heights[col][row] += 1; - } - break; - case FRAME_DIMENSION_PERCENT: - heights[col][row] = bw_height * - window->frame_height.value / 100; - break; - case FRAME_DIMENSION_RELATIVE: - heights[col][row] = 0; - relative += window->frame_height.value; - break; + case FRAME_DIMENSION_PIXELS: + heights[col][row] = window->frame_height.value * + window->scale; + if (window->border) { + if (row != 0) + heights[col][row] += 1; + if (row != bw->rows - 1) + heights[col][row] += 1; + } + break; + case FRAME_DIMENSION_PERCENT: + heights[col][row] = bw_height * + window->frame_height.value / 100; + break; + case FRAME_DIMENSION_RELATIVE: + heights[col][row] = 0; + relative += window->frame_height.value; + break; + default: + /* unknown frame dimension unit */ + assert(window->frame_height.unit == + FRAME_DIMENSION_PIXELS || + window->frame_height.unit == + FRAME_DIMENSION_PERCENT || + window->frame_height.unit == + FRAME_DIMENSION_RELATIVE); + break; } avail_height -= heights[col][row]; } -- cgit v1.2.3