From 5c02f9bd97305da6ec9c23e80286dc4e4234ee4c Mon Sep 17 00:00:00 2001 From: Vincent Sanders Date: Mon, 25 May 2020 11:28:35 +0100 Subject: rename browser window internal redraw request function remove confusing reference to boxes --- desktop/browser_private.h | 4 ++-- desktop/browser_window.c | 11 ++++++----- desktop/frames.c | 2 +- 3 files changed, 9 insertions(+), 8 deletions(-) (limited to 'desktop') diff --git a/desktop/browser_private.h b/desktop/browser_private.h index ed2d845de..8ed2ddef6 100644 --- a/desktop/browser_private.h +++ b/desktop/browser_private.h @@ -309,12 +309,12 @@ void browser_window_update_extent(struct browser_window *bw); /** - * update an area of a browser window. + * Cause an area of a browser window to be marked invalid and hence redrawn. * * \param bw The browser window to update. * \param rect The area to redraw */ -void browser_window_update_box(struct browser_window *bw, struct rect *rect); +nserror browser_window_invalidate_rect(struct browser_window *bw, struct rect *rect); /** diff --git a/desktop/browser_window.c b/desktop/browser_window.c index bd8e32e64..096b944fd 100644 --- a/desktop/browser_window.c +++ b/desktop/browser_window.c @@ -1465,7 +1465,7 @@ browser_window_callback(hlcache_handle *c, const hlcache_event *event, void *pw) .y1 = event->data.redraw.y + event->data.redraw.height }; - browser_window_update_box(bw, &rect); + browser_window_invalidate_rect(bw, &rect); } break; @@ -4065,7 +4065,7 @@ void browser_window_update(struct browser_window *bw, bool scroll_to_top) rect.x1 = rect.x0 + bw->width; rect.y1 = rect.y0 + bw->height; - browser_window_update_box(bw, &rect); + browser_window_invalidate_rect(bw, &rect); } break; @@ -4077,8 +4077,9 @@ void browser_window_update(struct browser_window *bw, bool scroll_to_top) } -/* Exported interface, documented in netsurf/browser_window.h */ -void browser_window_update_box(struct browser_window *bw, struct rect *rect) +/* Exported interface, documented in browser/browser_private.h */ +nserror +browser_window_invalidate_rect(struct browser_window *bw, struct rect *rect) { int pos_x; int pos_y; @@ -4103,7 +4104,7 @@ void browser_window_update_box(struct browser_window *bw, struct rect *rect) rect->x1 *= top->scale; rect->y1 *= top->scale; - guit->window->invalidate(top->window, rect); + return guit->window->invalidate(top->window, rect); } diff --git a/desktop/frames.c b/desktop/frames.c index a03f86c8f..0d70029e9 100644 --- a/desktop/frames.c +++ b/desktop/frames.c @@ -69,7 +69,7 @@ void browser_window_scroll_callback(void *client_data, rect.x1 = rect.x0 + bw->width; rect.y1 = rect.y0 + bw->height; - browser_window_update_box(bw, &rect); + browser_window_invalidate_rect(bw, &rect); } break; case SCROLLBAR_MSG_SCROLL_START: -- cgit v1.2.3