diff options
| author | John Mark Bell <jmb@netsurf-browser.org> | 2009-04-16 00:27:34 +0000 |
|---|---|---|
| committer | John Mark Bell <jmb@netsurf-browser.org> | 2009-04-16 00:27:34 +0000 |
| commit | b3018f84339a953a08333338d06a3d68506ee17d (patch) | |
| tree | 1adbcafd3c43a11dcb31b9bf2da0255b67b202d0 /src/parse | |
| parent | 71327cd21e3dcc793dd6e0cf99f5295e58e0322c (diff) | |
| download | libcss-b3018f84339a953a08333338d06a3d68506ee17d.tar.gz libcss-b3018f84339a953a08333338d06a3d68506ee17d.tar.bz2 | |
Flag use of alloca -- these need to die.
Why are we interning lowercased versions of strings, anyway?
svn path=/trunk/libcss/; revision=7102
Diffstat (limited to 'src/parse')
| -rw-r--r-- | src/parse/parse.c | 4 | ||||
| -rw-r--r-- | src/parse/properties.c | 2 |
2 files changed, 6 insertions, 0 deletions
diff --git a/src/parse/parse.c b/src/parse/parse.c index cc24385..f7fd2fb 100644 --- a/src/parse/parse.c +++ b/src/parse/parse.c @@ -582,7 +582,11 @@ css_error getToken(css_parser *parser, const css_token **token) */ if (t->type < CSS_TOKEN_LAST_INTERN && t->data.data != NULL) { + /** \todo Why are we interning lower cased versions, + * too? lwc_strings can easily be compared case + * insensitively */ if (t->type < CSS_TOKEN_LAST_INTERN_LOWER) { + /** \todo Don't use alloca */ uint8_t *temp = alloca(t->data.len); bool lower = false; size_t i; diff --git a/src/parse/properties.c b/src/parse/properties.c index 6294a6e..f2ca4b0 100644 --- a/src/parse/properties.c +++ b/src/parse/properties.c @@ -2859,6 +2859,7 @@ css_error parse_font_family(css_language *c, vector, &temp_ctx); } + /** \todo Don't use alloca */ buf = alloca(len); p = buf; @@ -6041,6 +6042,7 @@ css_error parse_voice_family(css_language *c, vector, &temp_ctx); } + /** \todo Don't use alloca */ buf = alloca(len); p = buf; |