diff options
author | Michael Drake <tlsa@netsurf-browser.org> | 2012-09-19 14:30:47 +0100 |
---|---|---|
committer | Michael Drake <tlsa@netsurf-browser.org> | 2012-09-19 14:30:47 +0100 |
commit | 47e3fe106a9cd7ae72272955194a0ea9ae528820 (patch) | |
tree | e7f5007bb16340d74190bca79db4fa861544fe80 | |
parent | d621b4cc86289f23b11f2050d5dcfbf025a3218f (diff) | |
download | libdom-47e3fe106a9cd7ae72272955194a0ea9ae528820.tar.gz libdom-47e3fe106a9cd7ae72272955194a0ea9ae528820.tar.bz2 |
Fix comparison of signed/unsigned variables.
-rw-r--r-- | .gitignore | 1 | ||||
-rw-r--r-- | include/dom/html/html_select_element.h | 2 | ||||
-rw-r--r-- | src/html/html_select_element.c | 4 |
3 files changed, 3 insertions, 4 deletions
@@ -3,5 +3,4 @@ build-* build/docs examples/dom-structure-dump test/level*.c -test/INDEX *~ diff --git a/include/dom/html/html_select_element.h b/include/dom/html/html_select_element.h index 6999368..42aef00 100644 --- a/include/dom/html/html_select_element.h +++ b/include/dom/html/html_select_element.h @@ -80,7 +80,7 @@ dom_exception dom__html_select_element_add(dom_html_select_element *select, (struct dom_html_element *) (e), \ (struct dom_html_element *) (b)) dom_exception dom_html_select_element_remove(dom_html_select_element *ele, - long index); + int32_t index); dom_exception dom_html_select_element_blur(struct dom_html_select_element *ele); dom_exception dom_html_select_element_focus(struct dom_html_select_element *ele); diff --git a/src/html/html_select_element.c b/src/html/html_select_element.c index 4efffb9..12ea6ba 100644 --- a/src/html/html_select_element.c +++ b/src/html/html_select_element.c @@ -536,7 +536,7 @@ dom_exception dom__html_select_element_add(dom_html_select_element *select, } dom_exception dom_html_select_element_remove(dom_html_select_element *ele, - long index) + int32_t index) { dom_exception err; uint32_t len; @@ -547,7 +547,7 @@ dom_exception dom_html_select_element_remove(dom_html_select_element *ele, return err; /* Ensure index is in range */ - if (index >= len) + if (index < 0 || (uint32_t)index >= len) return DOM_NO_ERR; err = dom_html_options_collection_item(ele->options, index, &option); |