From 464fe3793d4bba82ff3fe859b81c0dd42d54544c Mon Sep 17 00:00:00 2001 From: Daniel Silverstone Date: Mon, 6 Aug 2012 11:26:23 +0100 Subject: DOMDocument::_dom_find_element_by_id: Only compare ids, if the element *has* one --- src/core/document.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) (limited to 'src') diff --git a/src/core/document.c b/src/core/document.c index 456d906..6284897 100644 --- a/src/core/document.c +++ b/src/core/document.c @@ -1233,14 +1233,15 @@ dom_exception _dom_find_element_by_id(dom_node_internal *root, dom_string *real_id; _dom_element_get_id((dom_element *) node, &real_id); + if (real_id != NULL) { + if (dom_string_isequal(real_id, id)) { + dom_string_unref(real_id); + *result = (dom_element *) node; + return DOM_NO_ERR; + } - if (dom_string_isequal(real_id, id)) { dom_string_unref(real_id); - *result = (dom_element *) node; - return DOM_NO_ERR; } - - dom_string_unref(real_id); } if (node->first_child != NULL) { -- cgit v1.2.3