diff options
| author | Chris Young <chris@unsatisfactorysoftware.co.uk> | 2015-02-01 23:06:28 +0000 |
|---|---|---|
| committer | Chris Young <chris@unsatisfactorysoftware.co.uk> | 2015-02-01 23:06:28 +0000 |
| commit | c9e8aa94b0255f928bdd63539b333ff1f56f62f8 (patch) | |
| tree | fc547b4f22f5ef60d731ac6a60cbd75d7e83abf7 | |
| parent | 7b0969680b2e6fa378bc5ed34b6157268e54a695 (diff) | |
| download | netsurf-c9e8aa94b0255f928bdd63539b333ff1f56f62f8.tar.gz netsurf-c9e8aa94b0255f928bdd63539b333ff1f56f62f8.tar.bz2 | |
Fix a potential memory leak when setting titles
| -rw-r--r-- | amiga/gui.c | 12 |
1 files changed, 7 insertions, 5 deletions
diff --git a/amiga/gui.c b/amiga/gui.c index c3a7424eb..4ae03b797 100644 --- a/amiga/gui.c +++ b/amiga/gui.c @@ -4267,8 +4267,11 @@ static void gui_window_set_title(struct gui_window *g, const char *title) CLICKTAB_Labels, ~0, TAG_DONE); - SetClickTabNodeAttrs(node, TNA_Text, utf8title, - TNA_HintInfo, utf8title, + if(g->tabtitle) ami_utf8_free(g->tabtitle); + g->tabtitle = strdup(utf8title); + + SetClickTabNodeAttrs(node, TNA_Text, g->tabtitle, + TNA_HintInfo, g->tabtitle, TAG_DONE); RefreshSetGadgetAttrs((struct Gadget *)g->shared->objects[GID_TABS], @@ -4276,9 +4279,6 @@ static void gui_window_set_title(struct gui_window *g, const char *title) CLICKTAB_Labels, &g->shared->tab_list, TAG_DONE); - if(g->tabtitle) ami_utf8_free(g->tabtitle); - g->tabtitle = utf8title; - if(ClickTabBase->lib_Version < 53) RethinkLayout((struct Gadget *)g->shared->objects[GID_TABLAYOUT], g->shared->win, NULL, TRUE); @@ -4293,6 +4293,8 @@ static void gui_window_set_title(struct gui_window *g, const char *title) SetWindowTitles(g->shared->win, g->shared->wintitle, ami_gui_get_screen_title()); } } + + ami_utf8_free(utf8title); } static void ami_redraw_callback(void *p) |