Change LOG() macro to be varadic

This changes the LOG macro to be varadic removing the need for all
callsites to have double bracketing and allows for future improvement
on how we use the logging macros.

The callsites were changed with coccinelle and the changes checked by
hand. Compile tested for several frontends but not all.

A formatting annotation has also been added which allows the compiler
to check the parameters and types passed to the logging.

1 files changed, 7 insertions, 7 deletions

diff --git a/atari/history.c b/atari/history.c
index cb2ba9e17..f048b0bbe 100644
--- a/atari/history.c
+++ b/atari/history.c
@@ -72,13 +72,13 @@ static struct atari_treeview_callbacks atari_global_history_treeview_callbacks =
 static nserror atari_global_history_init_phase2(struct core_window *cw,
 						struct core_window_callback_table *cb_t)
 {
-	LOG((""));
+	LOG("");
 	return(global_history_init(cb_t, cw));
 }
 
 static void atari_global_history_finish(struct core_window *cw)
 {
-	LOG((""));
+	LOG("");
 	global_history_fini();
 }
 
@@ -91,7 +91,7 @@ static void atari_global_history_draw(struct core_window *cw, int x,
 
 static void atari_global_history_keypress(struct core_window *cw, uint32_t ucs4)
 {
-	LOG(("ucs4: %lu\n", ucs4));
+	LOG("ucs4: %lu\n", ucs4);
 	global_history_keypress(ucs4);
 }
 
@@ -99,7 +99,7 @@ static void atari_global_history_mouse_action(struct core_window *cw,
 					      browser_mouse_state mouse,
 					      int x, int y)
 {
-	LOG(("x:  %d, y: %d\n", x, y));
+	LOG("x:  %d, y: %d\n", x, y);
 
 	global_history_mouse_action(mouse, x, y);
 
@@ -111,7 +111,7 @@ static short handle_event(GUIWIN *win, EVMULT_OUT *ev_out, short msg[8])
 {
 	short retval = 0;
 
-	LOG((""));
+	LOG("");
 
 	if (ev_out->emo_events & MU_MESAG) {
 		switch (msg[0]) {
@@ -156,7 +156,7 @@ void atari_global_history_init(void)
 
 			if (atari_global_history.tv == NULL) {
 				/* handle it properly, clean up previous allocs */
-				LOG(("Failed to allocate treeview"));
+				LOG("Failed to allocate treeview");
 				return;
 			}
 		}
@@ -207,7 +207,7 @@ void atari_global_history_destroy(void)
 		atari_treeview_delete(atari_global_history.tv);
 		atari_global_history.init = false;
 	}
-	LOG(("done"));
+	LOG("done");
 }
 
 void atari_global_history_redraw(void)