Change LOG() macro to be varadic

This changes the LOG macro to be varadic removing the need for all
callsites to have double bracketing and allows for future improvement
on how we use the logging macros.

The callsites were changed with coccinelle and the changes checked by
hand. Compile tested for several frontends but not all.

A formatting annotation has also been added which allows the compiler
to check the parameters and types passed to the logging.

1 files changed, 14 insertions, 14 deletions

diff --git a/desktop/textarea.c b/desktop/textarea.c
index a2e6c167b..9970bd6ab 100644
--- a/desktop/textarea.c
+++ b/desktop/textarea.c
@@ -828,7 +828,7 @@ static bool textarea_reflow_singleline(struct textarea *ta, size_t b_off,
 		ta->lines =
 			malloc(LINE_CHUNK_SIZE * sizeof(struct line_info));
 		if (ta->lines == NULL) {
-			LOG(("malloc failed"));
+			LOG("malloc failed");
 			return false;
 		}
 		ta->lines_alloc_size = LINE_CHUNK_SIZE;
@@ -852,7 +852,7 @@ static bool textarea_reflow_singleline(struct textarea *ta, size_t b_off,
 			char *temp = realloc(ta->password.data,
 					b_len + TA_ALLOC_STEP);
 			if (temp == NULL) {
-				LOG(("realloc failed"));
+				LOG("realloc failed");
 				return false;
 			}
 
@@ -936,7 +936,7 @@ static bool textarea_reflow_multiline(struct textarea *ta,
 	if (ta->lines == NULL) {
 		ta->lines = calloc(sizeof(struct line_info), LINE_CHUNK_SIZE);
 		if (ta->lines == NULL) {
-			LOG(("Failed to allocate memory for textarea lines"));
+			LOG("Failed to allocate memory for textarea lines");
 			return false;
 		}
 		ta->lines_alloc_size = LINE_CHUNK_SIZE;
@@ -1052,7 +1052,7 @@ static bool textarea_reflow_multiline(struct textarea *ta,
 						(line + 2 + LINE_CHUNK_SIZE) *
 						sizeof(struct line_info));
 				if (temp == NULL) {
-					LOG(("realloc failed"));
+					LOG("realloc failed");
 					return false;
 				}
 
@@ -1332,7 +1332,7 @@ static bool textarea_insert_text(struct textarea *ta, const char *text,
 		char *temp = realloc(ta->text.data, b_len + ta->text.len +
 				TA_ALLOC_STEP);
 		if (temp == NULL) {
-			LOG(("realloc failed"));
+			LOG("realloc failed");
 			return false;
 		}
 
@@ -1482,7 +1482,7 @@ static bool textarea_replace_text_internal(struct textarea *ta, size_t b_start,
 				rep_len + ta->text.len - (b_end - b_start) +
 					TA_ALLOC_STEP);
 		if (temp == NULL) {
-			LOG(("realloc failed"));
+			LOG("realloc failed");
 			return false;
 		}
 
@@ -1559,7 +1559,7 @@ static bool textarea_copy_to_undo_buffer(struct textarea *ta,
 		char *temp = realloc(undo->text.data,
 				b_offset + len + TA_ALLOC_STEP);
 		if (temp == NULL) {
-			LOG(("realloc failed"));
+			LOG("realloc failed");
 			return false;
 		}
 
@@ -1573,7 +1573,7 @@ static bool textarea_copy_to_undo_buffer(struct textarea *ta,
 				(undo->next_detail + 128) *
 				sizeof(struct textarea_undo_detail));
 		if (temp == NULL) {
-			LOG(("realloc failed"));
+			LOG("realloc failed");
 			return false;
 		}
 
@@ -1833,13 +1833,13 @@ struct textarea *textarea_create(const textarea_flags flags,
 			flags & TEXTAREA_PASSWORD));
 
 	if (callback == NULL) {
-		LOG(("no callback provided"));
+		LOG("no callback provided");
 		return NULL;
 	}
 
 	ret = malloc(sizeof(struct textarea));
 	if (ret == NULL) {
-		LOG(("malloc failed"));
+		LOG("malloc failed");
 		return NULL;
 	}
 
@@ -1886,7 +1886,7 @@ struct textarea *textarea_create(const textarea_flags flags,
 
 	ret->text.data = malloc(TA_ALLOC_STEP);
 	if (ret->text.data == NULL) {
-		LOG(("malloc failed"));
+		LOG("malloc failed");
 		free(ret);
 		return NULL;
 	}
@@ -1898,7 +1898,7 @@ struct textarea *textarea_create(const textarea_flags flags,
 	if (flags & TEXTAREA_PASSWORD) {
 		ret->password.data = malloc(TA_ALLOC_STEP);
 		if (ret->password.data == NULL) {
-			LOG(("malloc failed"));
+			LOG("malloc failed");
 			free(ret->text.data);
 			free(ret);
 			return NULL;
@@ -1973,7 +1973,7 @@ bool textarea_set_text(struct textarea *ta, const char *text)
 	if (len >= ta->text.alloc) {
 		char *temp = realloc(ta->text.data, len + TA_ALLOC_STEP);
 		if (temp == NULL) {
-			LOG(("realloc failed"));
+			LOG("realloc failed");
 			return false;
 		}
 		ta->text.data = temp;
@@ -2060,7 +2060,7 @@ int textarea_get_text(struct textarea *ta, char *buf, unsigned int len)
 	}
 
 	if (len < ta->text.len) {
-		LOG(("buffer too small"));
+		LOG("buffer too small");
 		return -1;
 	}