From 2754918e250aa553fe090ec7423c1fac57b007cc Mon Sep 17 00:00:00 2001 From: Michael Drake Date: Wed, 23 Oct 2013 18:55:00 +0100 Subject: Fix leak of path_query, when there is no host and scheme isn't file. --- content/urldb.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) (limited to 'content/urldb.c') diff --git a/content/urldb.c b/content/urldb.c index 3cf65494a..e46245152 100644 --- a/content/urldb.c +++ b/content/urldb.c @@ -796,7 +796,7 @@ bool urldb_add_url(nsurl *url) lwc_string *host; lwc_string *fragment; const char *host_str; - char *path_query; + char *path_query = NULL; size_t len; bool match; unsigned int port_int; @@ -816,10 +816,13 @@ bool urldb_add_url(nsurl *url) NSERROR_OK) { return false; } + assert(path_query != NULL); scheme = nsurl_get_component(url, NSURL_SCHEME); - if (scheme == NULL) + if (scheme == NULL) { + free(path_query); return false; + } host = nsurl_get_component(url, NSURL_HOST); if (host != NULL) { @@ -832,6 +835,7 @@ bool urldb_add_url(nsurl *url) } else { lwc_string_unref(scheme); + free(path_query); return false; } -- cgit v1.2.3