From 9cf51227979c84a9ed74c339290c3f65f0d58c4f Mon Sep 17 00:00:00 2001 From: John Mark Bell Date: Sun, 11 Mar 2007 22:08:57 +0000 Subject: Content handlers should not call warn_user - they should broadcast the error using content_broadcast and leave it to the content owner(s) to decide what to do about it. Only use warn_user for top-level contents. svn path=/trunk/netsurf/; revision=3204 --- desktop/browser.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) (limited to 'desktop/browser.c') diff --git a/desktop/browser.c b/desktop/browser.c index 0273917bc..54a112f27 100644 --- a/desktop/browser.c +++ b/desktop/browser.c @@ -458,7 +458,11 @@ void browser_window_callback(content_msg msg, struct content *c, case CONTENT_MSG_ERROR: browser_window_set_status(bw, data.error); - warn_user(data.error, 0); + + /* Only warn the user about errors in top-level windows */ + if (bw->browser_window_type == BROWSER_WINDOW_NORMAL) + warn_user(data.error, 0); + if (c == bw->loading_content) bw->loading_content = 0; else if (c == bw->current_content) { -- cgit v1.2.3