From be7a45fefed2736f7ed7f1799e9f2b1cd52235b7 Mon Sep 17 00:00:00 2001 From: Vincent Sanders Date: Tue, 16 Jun 2015 00:20:37 +0100 Subject: Change gtk to use resource API for throbber --- gtk/gui.c | 41 ++++++----------------------------------- 1 file changed, 6 insertions(+), 35 deletions(-) (limited to 'gtk/gui.c') diff --git a/gtk/gui.c b/gtk/gui.c index 90991dae9..1df7bfc56 100644 --- a/gtk/gui.c +++ b/gtk/gui.c @@ -84,8 +84,6 @@ GdkPixbuf *win_default_icon_pixbuf; /** default window icon pixbuf */ GtkBuilder *warning_builder; -#define THROBBER_FRAMES 9 - char **respaths; /** resource search path vector */ /** @@ -125,36 +123,6 @@ nsgtk_init_resource(const char *resource_path) return respath; } -/* This is an ugly hack to just get the new-style throbber going. - * It, along with the PNG throbber loader, need making more generic. - */ -static bool nsgtk_throbber_init(char **respath, int framec) -{ - char **filenames; - char targetname[PATH_MAX]; - int frame_num; - bool ret; - - filenames = calloc(framec, sizeof(char *)); - if (filenames == NULL) - return false; - - for (frame_num = 0; frame_num < framec; frame_num++) { - snprintf(targetname, PATH_MAX, "throbber/throbber%d.png", frame_num); - filenames[frame_num] = filepath_find(respath, targetname); - } - - ret = nsgtk_throbber_initialise_from_png(frame_num, filenames); - - for (frame_num = 0; frame_num < framec; frame_num++) { - free(filenames[frame_num]); - } - free(filenames); - - return ret; - -} - /** * Set option defaults for gtk frontend. @@ -307,9 +275,12 @@ static nserror nsgtk_init(int argc, char** argv, char **respath) toolbar_indices_file_location = filepath_find(respath, "toolbarIndices"); LOG("Using '%s' as custom toolbar settings file", toolbar_indices_file_location); - /* load throbber images */ - if (nsgtk_throbber_init(respath, THROBBER_FRAMES) == false) - die("Unable to load throbber image.\n"); + /* initialise throbber */ + error = nsgtk_throbber_init(); + if (error != NSERROR_OK) { + LOG("Unable to initialise throbber."); + return error; + } /* Initialise completions - cannot fail */ nsgtk_completion_init(); -- cgit v1.2.3