From 881b4d447dd7b33a382bb7945d2aa4e055c68384 Mon Sep 17 00:00:00 2001
From: Vincent Sanders <vince@kyllikki.org>
Date: Mon, 18 Aug 2014 15:03:15 +0100
Subject: fix leaking of title text (coverity 1229480)

---
 gtk/viewsource.c | 13 ++++---------
 1 file changed, 4 insertions(+), 9 deletions(-)

(limited to 'gtk/viewsource.c')

diff --git a/gtk/viewsource.c b/gtk/viewsource.c
index cbcbad712..9c28f6927 100644
--- a/gtk/viewsource.c
+++ b/gtk/viewsource.c
@@ -16,14 +16,10 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-#include <stdlib.h>
-#include <string.h>
-#include <stdbool.h>
 #include <gtk/gtk.h>
 
-#include "utils/nsurl.h"
-#include "utils/url.h"
 #include "utils/utils.h"
+#include "utils/url.h"
 #include "utils/utf8.h"
 #include "utils/messages.h"
 #include "desktop/browser.h"
@@ -71,11 +67,10 @@ void nsgtk_viewsource(GtkWindow *parent, struct browser_window *bw)
 			  source_size,
 			  &ndata,
 			  &ndata_len);
-	if (ret != NSERROR_OK) {
-	free(filename);
-		return;
+	if (ret == NSERROR_OK) {
+		ret = nsgtk_viewdata(title, filename, ndata, ndata_len);
 	}
 
-	ret = nsgtk_viewdata(title, filename, ndata, ndata_len);
 	free(filename);
+	free(title);
 }
-- 
cgit v1.2.3