DOM Strings are now capable of containing either UTF-8 or UTF-16 encoded data.

The charset used for strings within a document is specified at document creation time. Whilst it is possible to mix charsets within a document, it's not recommended.

Things that need fixing:

+ dom_string_get_data() doesn't return the charset. Better would be to permit
  the client to request a charset for the data to be returned in.
+ Interned node name strings will break if the document is UTF-16 
  (dom_document_create()). In fact, these could quite happily be globals,
  rather than allocating a set for each document.
+ Other usage of dom string constructors need checking for sanity
+ DOM Strings need to gain more utility APIs (such as getting the character
  length of a string, string concatenation etc).


svn path=/trunk/dom/; revision=3614

1 files changed, 2 insertions, 0 deletions

diff --git a/src/utils/namespace.c b/src/utils/namespace.c
index 25b56ee..8a53e45 100644
--- a/src/utils/namespace.c
+++ b/src/utils/namespace.c
@@ -29,6 +29,7 @@ dom_exception _dom_namespace_initialise(dom_alloc alloc, void *pw)
 	dom_exception err;
 
 	err = dom_string_create_from_ptr_no_doc(alloc, pw,
+		DOM_STRING_UTF8,
 		(const uint8_t *) "http://www.w3.org/XML/1998/namespace", 
 		SLEN("http://www.w3.org/XML/1998/namespace"),
 		&xml);
@@ -37,6 +38,7 @@ dom_exception _dom_namespace_initialise(dom_alloc alloc, void *pw)
 	}
 
 	err = dom_string_create_from_ptr_no_doc(alloc, pw,
+		DOM_STRING_UTF8,
 		(const uint8_t *) "http://www.w3.org/2000/xmlns",
 		SLEN("http://www.w3.org/2000/xmlns"),
 		&xmlns);