1 files changed, 65 insertions, 48 deletions

diff --git a/gtk/gtk_throbber.c b/gtk/gtk_throbber.c
index d6b511f89..9070c61ba 100644
--- a/gtk/gtk_throbber.c
+++ b/gtk/gtk_throbber.c
@@ -1,5 +1,6 @@
 /*
  * Copyright 2008 Rob Kendrick <rjek@netsurf-browser.org>
+ * Copyright 2008 Sean Fox <dyntryx@gmail.com>
  *
  * This file is part of NetSurf, http://www.netsurf-browser.org/
  *
@@ -19,8 +20,8 @@
 #include <stdio.h>
 #include <stdlib.h>
 #include <stdarg.h>
+#include <libnsgif.h>
 #include "utils/log.h"
-#include "image/gifread.h"
 #include "gtk/gtk_throbber.h"
 #include "gtk/gtk_bitmap.h"
 
@@ -98,8 +99,13 @@ bool nsgtk_throbber_initialise_from_gif(const char *fn)
 	/* disect the GIF provided by filename in *fn into a series of
 	 * GdkPixbuf for use later.
 	 */
-	struct gif_animation *gif;		/**< structure for gifread.c */
-	struct nsgtk_throbber *throb;		/**< structure we generate */
+	extern gif_bitmap_callback_vt gif_bitmap_callbacks;	/**< external structure containing
+								*  bitmap callback functions */
+	gif_animation gif;
+	struct nsgtk_throbber throb;				/**< structure we generate */
+	int res;
+	size_t size;
+	unsigned char *data;
 	int i;
 
 	FILE *fh = fopen(fn, "rb");
@@ -109,77 +115,88 @@ bool nsgtk_throbber_initialise_from_gif(const char *fn)
 		return false;
 	}
 
-	gif = (struct gif_animation *)malloc(sizeof(struct gif_animation));
-	throb = (struct nsgtk_throbber *)malloc(sizeof(struct nsgtk_throbber));
-
 	/* discover the size of the data file. */
 	fseek(fh, 0, SEEK_END);
-	gif->buffer_size = ftell(fh);
+	size = ftell(fh);
 	fseek(fh, 0, SEEK_SET);
 
 	/* allocate a block of sufficient size, and load the data in. */
-	gif->gif_data = (unsigned char *)malloc(gif->buffer_size);
-	fread(gif->gif_data, gif->buffer_size, 1, fh);
+	data = (unsigned char *)malloc(size);
+	fread(data, size, 1, fh);
 	fclose(fh);
 
-	/* set current position within GIF file to beginning, in order to
-	 * signal to gifread that we're brand new.
-	 */
-	gif->buffer_position = 0;
+	/* create our gif animation */
+	gif_create(&gif, &gif_bitmap_callbacks);
 
 	/* initialise the gif_animation structure. */
-	switch (gif_initialise(gif))
-	{
-		case GIF_INSUFFICIENT_FRAME_DATA:
-		case GIF_FRAME_DATA_ERROR:
-		case GIF_INSUFFICIENT_DATA:
-		case GIF_DATA_ERROR:
-			LOG(("GIF image '%s' appears invalid!", fn));
-			free(gif->gif_data);
-			free(gif);
-			free(throb);
-			return false;
-			break;
-		case GIF_INSUFFICIENT_MEMORY:
-			LOG(("Ran out of memory decoding GIF image '%s'!", fn));
-			free(gif->gif_data);
-			free(gif);
-			free(throb);
+	do {
+		res = gif_initialise(&gif, size, data);
+		if (res != GIF_OK && res != GIF_WORKING) {
+			switch (res)
+			{
+				case GIF_INSUFFICIENT_FRAME_DATA:
+				case GIF_FRAME_DATA_ERROR:
+				case GIF_INSUFFICIENT_DATA:
+				case GIF_DATA_ERROR:
+					LOG(("GIF image '%s' appears invalid!", fn));
+					break;
+				case GIF_INSUFFICIENT_MEMORY:
+					LOG(("Ran out of memory decoding GIF image '%s'!", fn));
+					break;
+			}
+			gif_finalise(&gif);
+			free(data);
+			free(&throb);
 			return false;
-			break;
-	}
+		}
+	} while (res != GIF_OK);
 
-	throb->nframes = gif->frame_count;
+	throb.nframes = gif.frame_count;
 
-	if (throb->nframes < 2)
+	if (throb.nframes < 2)
 	{
 		/* we need at least two frames - one for idle, one for active */
 		LOG(("Insufficent number of frames in throbber image '%s'!",
 			fn));
 		LOG(("(GIF contains %d frames, where 2 is a minimum.)",
-			throb->nframes));
-		free(gif->gif_data);
-		free(gif);
-		free(throb);
+			throb.nframes));
+		gif_finalise(&gif);
+		free(data);
+		free(&throb);
 		return false;
 	}
 
-	throb->framedata = (GdkPixbuf **)malloc(sizeof(GdkPixbuf *)
-						* throb->nframes);
+	throb.framedata = (GdkPixbuf **)malloc(sizeof(GdkPixbuf *) * throb.nframes);
 
 	/* decode each frame in turn, extracting the struct bitmap * for each,
 	 * and put that in our array of frames.
 	 */
-	for (i = 0; i < throb->nframes; i++)
+	for (i = 0; i < throb.nframes; i++)
 	{
-		gif_decode_frame(gif, i);
-		throb->framedata[i] = gdk_pixbuf_copy(
-				gtk_bitmap_get_primary(gif->frame_image));
+		res = gif_decode_frame(&gif, i);
+		if (res != GIF_OK) {
+			switch (res)
+			{
+				case GIF_INSUFFICIENT_FRAME_DATA:
+				case GIF_FRAME_DATA_ERROR:
+				case GIF_INSUFFICIENT_DATA:
+				case GIF_DATA_ERROR:
+					LOG(("GIF image '%s' appears invalid!", fn));
+					break;
+				case GIF_INSUFFICIENT_MEMORY:
+					LOG(("Ran out of memory decoding GIF image '%s'!", fn));
+					break;
+			}
+			gif_finalise(&gif);
+			free(data);
+			free(&throb);
+			return false;
+		}
+		throb.framedata[i] = gdk_pixbuf_copy(gtk_bitmap_get_primary(gif.frame_image));
 	}
 
-	gif_finalise(gif);
-	free(gif->gif_data);
-	free(gif);
+	gif_finalise(&gif);
+	free(data);
 
 	/* debug code: save out each frame as a PNG to make sure decoding is
 	 * working correctly.
@@ -191,7 +208,7 @@ bool nsgtk_throbber_initialise_from_gif(const char *fn)
 	}
   	*/
 
-	nsgtk_throbber = throb;
+	nsgtk_throbber = &throb;
 
 	return true;
 }